chore: use vite+ #643

fengmk2 · 2026-01-15T14:06:03Z

No description provided.

coderabbitai · 2026-01-15T14:06:13Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

socket-security · 2026-01-15T14:06:42Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	vite-plus@0.0.0-ab0b0858cb619f270f5e0a698fea3d6f5622a761

View full report

socket-security · 2026-01-15T14:06:44Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `@voidzero-dev/vite-plus-core` is 91.0% likely obfuscated Confidence: 0.91 Location: Package overview From: pnpm-lock.yaml → `npm/@vitest/[email protected]` → `npm/[email protected]` → `npm/@voidzero-dev/[email protected]` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@voidzero-dev/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

pkg-pr-new · 2026-01-15T14:06:59Z

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@643

commit: f10bc97

gemini-code-assist · 2026-01-15T14:07:02Z

Summary of Changes

Hello @fengmk2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly overhauls the project's development infrastructure by adopting Vite+ as the primary and unified toolchain. This strategic shift aims to simplify the development experience by centralizing commands for code quality checks, testing, and other build processes under a single interface. The changes ensure a more cohesive and efficient workflow, backed by detailed guidelines for seamless integration and usage.

Highlights

Toolchain Migration to Vite+: The project has fully migrated its development toolchain to Vite+, consolidating various development tasks under a single, unified CLI.
Streamlined Commands: Linting, formatting, and testing commands in package.json scripts have been updated to use the vite CLI (e.g., vite lint, vite fmt, vite test), replacing direct calls to oxlint, oxfmt, and vitest.
Dependency Updates: Standalone oxlint and oxfmt dependencies have been removed, and vitest has been aliased to a vite-plus specific version. The vite-plus package has been added as a core dependency.
Updated Test Imports: All test files now import testing utilities (like describe, it) from vite-plus/test instead of vitest, aligning with the new toolchain.
Comprehensive Documentation: Extensive documentation has been added to CLAUDE.md, detailing the Vite+ workflow, available commands, package manager integration, common pitfalls, and a review checklist.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

codecov · 2026-01-15T14:07:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (d748999) to head (fbca0e3).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   93.82%   92.77%   -1.06%     
==========================================
  Files          14       10       -4     
  Lines        1474      747     -727     
  Branches      289      233      -56     
==========================================
- Hits         1383      693     -690     
+ Misses         85       51      -34     
+ Partials        6        3       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gemini-code-assist

Code Review

This pull request migrates the project's tooling to vite+, a unified toolchain. This involves removing the standalone configurations for oxlint and oxfmt and consolidating them into vite.config.ts. The package.json scripts and dependencies have been updated accordingly to use vite+ commands. Additionally, test files have been updated to import from vite-plus/test, and documentation has been added to CLAUDE.md to explain the new workflow. The changes are mostly correct and align with the goal of adopting vite+. I've found one potential issue in the new vite.config.ts regarding a configuration path that seems incorrect.

gemini-code-assist · 2026-01-15T14:09:13Z

vite.config.ts

+    env: {
+      node: true,
+    },
+    extends: ['../../@eggjs/oxlint-config/.oxlintrc.json'],


The path for extends in the lint configuration appears to be incorrect. Since vite.config.ts is at the project root, the path to the configuration file within node_modules should be relative to the root. The previous configuration in .oxlintrc.json used ./node_modules/@eggjs/oxlint-config/.oxlintrc.json, which seems correct. The current path ../../@eggjs/oxlint-config/.oxlintrc.json navigates up two directories from the project root, which is likely not the intended location. This could cause the extended linting rules to not be applied.

Suggested change

extends: ['../../@eggjs/oxlint-config/.oxlintrc.json'],

extends: ['./node_modules/@eggjs/oxlint-config/.oxlintrc.json'],

chore: use vite+

efb68f9

gemini-code-assist bot reviewed Jan 15, 2026

View reviewed changes

fengmk2 added 21 commits January 15, 2026 22:14

FIXUP

6669a98

FIXUP

84508f2

FIXUP

fba5a32

FIXUP

928555f

FIXUP

717eca9

FIXUP

e1749d6

FIXUP

a8b92fc

FIXUP

0fb6055

FIXUP

679eceb

FIXUP

cb38bb9

FIXUP

45497a3

FIXUP

7f7b205

FIXUP

ee2dbb2

FIXUP

f10bc97

FIXUP

ad05ba1

FIXUP

8f54533

FIXUP

ac550ac

FIXUP

490e86d

FIXUP

6bd9b5a

FIXUP

9a26e45

FIXUP

fbca0e3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: use vite+ #643

chore: use vite+ #643

fengmk2 commented Jan 15, 2026

Uh oh!

coderabbitai bot commented Jan 15, 2026 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

socket-security bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 15, 2026

Uh oh!

codecov bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	extends: ['../../@eggjs/oxlint-config/.oxlintrc.json'],
	extends: ['./node_modules/@eggjs/oxlint-config/.oxlintrc.json'],

chore: use vite+ #643

Are you sure you want to change the base?

chore: use vite+ #643

Conversation

fengmk2 commented Jan 15, 2026

Uh oh!

coderabbitai bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

socket-security bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 15, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

codecov bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 15, 2026 •

edited

Loading

socket-security bot commented Jan 15, 2026 •

edited

Loading

socket-security bot commented Jan 15, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 15, 2026 •

edited

Loading

codecov bot commented Jan 15, 2026 •

edited

Loading